antlr4-cpp-runtime: Remove additional gtest pkconfigs/includes #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** The build previously downloaded its own copy of googletest and installed its pkgconfigs/includes. This removes the fetching part, so it uses the system `gtest` instead, thus also no longer requiring networking. Signed-off-by: Thomas Staudinger <[email protected]>
|
Have you tried passing |
|
That seems to work too, yes, thanks. I didn't know that switch would be in the upstream gtest project, only looked at the antlr4 files. It does however require enabling networking again. So I'm not sure what would be the better approach. |
Signed-off-by: Gavin Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The build previously downloaded its own copy of googletest and installed its pkgconfigs/includes. This removes the fetching part, so it uses the system
gtestinstead, thus also no longer requiring networking.Test Plan
Confirmed gtest/gmock files are no longer installed.
Checklist