Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdl-gfx: update to 2.0.27 #2848

Closed
wants to merge 1 commit into from
Closed

sdl-gfx: update to 2.0.27 #2848

wants to merge 1 commit into from

Conversation

androidnisse
Copy link
Contributor

Summary

  • Updated version numbers for next release
  • fixed printf bug in test program
  • fixed VS code analysis warnings
  • fixed rotozoom locking bug
  • fixed rotozoom colorkey bug
  • updated VS2015 solution files to VS2022 solution files and rename
  • deprecated VS2008 and VS2010 solution files
  • updated .vcxproj files for SDL-1.2 source and release path
  • moved ChangeLog to solution items

Test Plan

  • Checked it installed.

Checklist

  • Package was built and tested against unstable

@androidnisse
sdl-gfx: update to 2.0.27
949055d 
**Summary**
- Updated version numbers for next release
- fixed printf bug in test program
- fixed VS code analysis warnings
- fixed rotozoom locking bug
- fixed rotozoom colorkey bug
- updated VS2015 solution files to VS2022 solution files and rename
- deprecated VS2008 and VS2010 solution files
- updated .vcxproj files for SDL-1.2 source and release path
- moved ChangeLog to solution items
EbonJaeger
EbonJaeger reviewed Jun 19, 2024
View reviewed changes
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebuild one of the packages that depends on sdl-gfx as a sanity check to make sure they build and run correctly? There are no library or symbol deletions, so it's probably fine, but just to make sure.

Otherwise, looks good.

@EbonJaeger
Copy link
Member

I just realized that there is also another PR open for sdl-gfx: #2648

@davidjharder @ReillyBrogan which one do we want?

@androidnisse androidnisse deleted the update_sdl-gfx branch June 21, 2024 06:26
@androidnisse androidnisse restored the update_sdl-gfx branch June 21, 2024 06:28
@androidnisse androidnisse reopened this Jun 21, 2024
@androidnisse
Copy link
Contributor Author

I just realized that there is also another PR open for sdl-gfx: #2648

@davidjharder @ReillyBrogan which one do we want?

Davids older so lets go with that one. It has rebuilds as well. :)

@androidnisse androidnisse deleted the update_sdl-gfx branch July 9, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EbonJaeger EbonJaeger EbonJaeger left review comments

Assignees
No one assigned
Labels
None yet
Projects
Solus
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@androidnisse @EbonJaeger