Convert py2 scripts in common/ to py3 #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Maddock <[email protected]>
Signed-off-by: Evan Maddock <[email protected]>
Signed-off-by: Evan Maddock <[email protected]>
|
I edited in the testing I did for the scripts I touched. :) |
|
@silke / @sheepman4267 / @joebonrichie Do any of you see any reason this should not go in as is? I am specifically wondering if not the smart thing to do here would be to test this PR against the stuff that's part of getsolus/3rd-party#73 ? |
ermo
added
Topic: Plumbing
joebonrichie
approved these changes
Apr 4, 2024
silkeh
reviewed
Apr 6, 2024
There was a problem hiding this comment.
Would you mind enabling flake8 for common/Scripts/*.py here and fixing the few minor issues that flake8 finds?
For reference, these are:
common/Scripts/yauto.py:127:54: E203 whitespace before ':'
common/Scripts/yauto.py:338:17: F841 local variable 'sample_actions' is assigned to but never used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2091.
Test Plan
I launched all the scripts I ported and made sure the output is meaningful. Where arguments are required, I used
mamefor package.yml-based packages and pisi for pspec.xml-based packages.Downloaded the
pspec.xmlfile forsublime-textfrom 3rd-party and ranyconvert.pyon it, and verified that the generatedpackage.ymlwas filled out as expected. Ranpbump.pyon the samepspec.xmland verified that there was a new history entry generated. Ranyauto.pywith a tarball forbudgie-desktopand verified that it generated and filled out apackage.ymlas expected.