ci/package_checks: Add check for included static libraries #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current list of failures: |
|
i think we need static zlib for the gnu toolchain, will have to check the git history to double check. |
What is the status on this @joebonrichie ? |
ermo
added
Topic: Tooling
joebonrichie
previously approved these changes
Oct 20, 2024
|
@silkeh Needs a rebase it looks like? |
ermo
added
Needs Rebase
**Summary** Add a check that fails when static libraries are included. Packages or paths that should contain static libraries can be allow-listed in the CI configuration.
silkeh
force-pushed
the
static-lib-check
branch
from
79a8ccf to
fd4718f
Compare
ermo
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a check that fails when static libraries are included.
Packages or paths that should contain static libraries can be allow-listed in the CI configuration.
Depends on #2038.
Test Plan
Checklist
Package was built and tested against unstable