Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapd: Confinement warning not shown when launching a snap from the GUI #4636

Open
2 tasks done
TraceyC77 opened this issue Dec 20, 2024 · 0 comments · May be fixed by #4668
Open
2 tasks done

snapd: Confinement warning not shown when launching a snap from the GUI #4636

TraceyC77 opened this issue Dec 20, 2024 · 0 comments · May be fixed by #4668
Assignees
Labels
Bug Something isn't working Topic: Tooling Tools and scripts

Comments

@TraceyC77
Copy link
Contributor

TraceyC77 commented Dec 20, 2024

Please confirm there isn't an open report for this issue

  • I have searched through bug reports

Summary

When launching any snap from the KDE app menu, no confinement warning is shown

Steps to reproduce

  1. Launch any snap (such as Spotify)
  2. Look for a pop up notification

Expected result

A pop up with the confinement warning

Actual result

No notification is seen

Environment

  • Is system up to date?

Repo

Unstable

Desktop Environment

Plasma

System details

Operating System: Solus 4.6
KDE Plasma Version: 6.2.4
KDE Frameworks Version: 6.9.0
Qt Version: 6.8.1
Kernel Version: 6.12.5-311.current (64-bit)
Graphics Platform: Wayland

Other comments

The functionality was introduced in this PR
I asked and verified that the GUI notification had not been tested
I exercised it while testing a more recent PR that updated the wording

The notification mechanism is nottify-send. I verified that invoking that on command line does show a notification on my system

The invocation of notify-send seems to be the problem. Trying this manually on command line gets:

❯ notify-send \
          --app-name Snap \
          --urgency normal \
          --icon dialog-warning \
          "Snap has ${CONFINEMENT} confinement" \
          "Snaps will stop working in early January 2025." \
          "See ${URL} for details."
Invalid number of options.

Three text lines is one too many.

@TraceyC77 TraceyC77 added Bug Something isn't working Topic: Tooling Tools and scripts labels Dec 20, 2024
@TraceyC77 TraceyC77 self-assigned this Dec 20, 2024
@github-project-automation github-project-automation bot moved this to Triage in Solus Dec 20, 2024
TraceyC77 pushed a commit that referenced this issue Dec 24, 2024
**Summary**
Fix text to be two lines not three per spec
Change urgency to critical so users must manually dismiss the notification
to give them time to copy the link

Resolves #4636
@TraceyC77 TraceyC77 linked a pull request Dec 24, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Topic: Tooling Tools and scripts
Projects
Status: Triage
Development

Successfully merging a pull request may close this issue.

1 participant