Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code element border radius and add padding #528

Merged
merged 1 commit into from
May 1, 2024

Conversation

Staudey
Copy link
Member

@Staudey Staudey commented Apr 27, 2024

Description

This reduces the border radius for code elements and slightly increases horizontal padding. The default rounding looks too extreme in my eyes, and makes it feel like the characters are not properly contained, especially with big vertical characters at the start or end of the element.

Before:

After:

Note: Personally I'm somewhat partial to a completely angular style for these elements, but this might be too extreme and/or not fit in with the rest of the theming

0 border radius:

It also looks more consistent across line breaks (which are not ideal in any case, but that's a different topic)

@Staudey
Copy link
Member Author

Staudey commented Apr 27, 2024

Actually now that I've prepared the PR the default no longer looks that bad to me, which it always has in the past. Maybe I need to rest my eyes for a while and look at it again.

@davidjharder
Copy link
Member

How do you feel with fresher eyes?

@Staudey
Copy link
Member Author

Staudey commented Apr 30, 2024

Yeah, I'm back to feeling the default is kinda meh. It seems especially bad to my eyes with the light theme. I could maybe do without the additional padding, but the border radius just feels off. Comments welcome.

@davidjharder davidjharder merged commit 7079cf4 into getsolus:master May 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants