Initial cspell and prettier support #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjharder
force-pushed
the
spelling
branch
3 times, most recently
from
95166e1 to
6c77e00
Compare
- Add cspell and prettier to yarn - Create a config and custom word-list for cspell - Update README - Add Github Action for cspell - Add Githun Action for prettier
davidjharder
force-pushed
the
spelling
branch
from
6c77e00 to
4b0f1c2
Compare
silkeh
reviewed
Jan 13, 2024
| name: 'Format with Prettier' | ||
| on: | ||
| pull_request: | ||
| branches: [master] |
There was a problem hiding this comment.
Is there a reason this one only runs when PR'ing against master?
There was a problem hiding this comment.
No, I just copied an example
There was a problem hiding this comment.
Ah, then it should be removed (for when we rename the branch to main 😉)
There was a problem hiding this comment.
This seems to be required. I do not know why
This is works on my fork, I think it fails here for some other reason I don't understand
Co-authored-by: Silke Hofstra <[email protected]>
Co-authored-by: Silke Hofstra <[email protected]>
|
YOLO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
cspellandprettierto the project asyarndependenciescspellcspellandprettierActions description
spellcheckcspellis used to check spelling against standard dictionaries and a custom word list.prettierSee these checks in action here: