Skip to content

Commit

Permalink
packaging-troubleshooting.md: Add chunk about bypassing checks
Browse files Browse the repository at this point in the history
- Certain git commands will trip up the pre-commit hooks and cause the
git command to fail, even where it should not.
- For now, add a chunk about how to bypass checks

Resolves #540
  • Loading branch information
davidjharder committed May 18, 2024
1 parent ad7c3e0 commit b784b81
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 2 deletions.
1 change: 1 addition & 0 deletions .cspell-allowed-words.txt
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@ qlen
qmake
qmlc
qosmio
qqwing
qsynth
qtile
quickstart
Expand Down
16 changes: 14 additions & 2 deletions docs/packaging/troubleshooting-packaging.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,23 @@ The `solbuild` cache at `/var/cache/solbuild` can grow to tens of gigabytes easi
sudo solbuild dc
```

## An old package using `%configure` doesn't build
### An old package using `%configure` doesn't build

- Replace `%configure` with `%reconfigure` and try again.
- If `%reconfigure` produces the error `configure: error: unrecognized option: '--runstatedir=/run'`, then use the new `%configure_no_runstatedir` macro

## Something is wrong with my solbuild profile
### Something is wrong with my solbuild profile

Try running `go-task solbuild-reset`. This will delete the solbuild cache and profile, then download and initialize a fresh copy of the default unstable profile.

###q Git commands fail and complain about package checks

```bash
git commit --amend
WRN packages/q/qqwing/package.yml:1: Package release is not incremented by 1
ERR packages/q/qqwing/pspec_x86_64.xml:1: Package release is not incremented by 1
Package checks failed: /home/user/solus-packages/common/CI/package_checks.py packages/q/qqwing/package.yml packages/q/qqwing/pspec_x86_64.xml
```

- Solus uses pre-commit hooks to check for simple errors. Right now, certain `git` commands can fail, particularly `git commit --amend` and `git commit --fixup`
- You can bypass the pre-commit hooks by adding the `no-verify` option, for example: `git commit --amend --no-verify`. Checks will still be run by GitHub after a Pull Request is created.

0 comments on commit b784b81

Please sign in to comment.