Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: Add Unsupported variant to CacheError and ObjectFileStatus (#1541)" #1551

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

loewenheim
Copy link
Contributor

This reverts commit 2474a74.

Rolling that commit out caused trouble in production. I'll redo it in several pieces to try and find the problem.

@loewenheim loewenheim requested a review from Swatinem November 15, 2024 09:25
@loewenheim loewenheim self-assigned this Nov 15, 2024
@loewenheim loewenheim requested a review from a team November 15, 2024 09:38
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so what exactly failed there?

@loewenheim
Copy link
Contributor Author

so what exactly failed there?

Deploying it to production caused CPU load to go crazy. It's the damnedest thing, I don't understand it at all. It may have nothing to do with the actual content of that PR.

@loewenheim loewenheim merged commit 5e0d476 into master Nov 15, 2024
13 checks passed
@loewenheim loewenheim deleted the fix/revert-cache-error branch November 15, 2024 09:44
loewenheim added a commit that referenced this pull request Nov 20, 2024
Second try of #1541. That PR was reverted in #1551 because of deployment
issues which turned out to be unrelated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants