Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't log entire S3 error as part of the message #1542

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: Don't log entire S3 error as part of the message #1542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions crates/symbolicator-service/src/download/s3.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,7 @@ impl S3Downloader {
// of these in production and figure out what we actually get here
tracing::error!(
error = &err as &dyn std::error::Error,
"S3 request timed out: {:?}",
err
"S3 request timed out",
);
return Err(CacheError::Timeout(Duration::ZERO));
}
Expand Down Expand Up @@ -169,7 +168,7 @@ impl S3Downloader {
tracing::error!(
error = &err as &dyn std::error::Error,
"S3 request failed: {:?}",
err
err.code(),
);
let details = err.to_string();
Err(CacheError::DownloadError(details))
Expand All @@ -179,7 +178,7 @@ impl S3Downloader {
};

if response.content_length == Some(0) {
tracing::debug!("Empty response from s3:{}{}", &bucket, &key);
tracing::debug!(bucket, key, "Empty response from s3");
return Err(CacheError::NotFound);
}

Expand Down
Loading