Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Add platform tag #1511

Merged
merged 2 commits into from
Aug 28, 2024
Merged

feat(metrics): Add platform tag #1511

merged 2 commits into from
Aug 28, 2024

Conversation

loewenheim
Copy link
Contributor

@loewenheim loewenheim commented Aug 19, 2024

This adds a configurable platform tag to metrics. If this is set, the platform (determined based on the Symbolicator's hostname) (read from the SYMBOLICATOR_PLATFORM env variable) will be reported with every metric.

Fixes #1509.

@mwarkentin
Copy link
Member

@loewenheim just saw this, I will try to take a look. I wonder if there's anything we could do by setting an extra environment variable which could contain a platform tag value. Would this be better than the host name parsing?

@loewenheim
Copy link
Contributor Author

@loewenheim just saw this, I will try to take a look. I wonder if there's anything we could do by setting an extra environment variable which could contain a platform tag value. Would this be better than the host name parsing?

Sorry for the late answer. From the Symbolicator code perspective it would be simple—we can just read the value of an environment variable. How complicated would it be from the configuration point of view?

@mwarkentin
Copy link
Member

@loewenheim pretty easy (I think): https://github.com/getsentry/ops/pull/11922

@loewenheim
Copy link
Contributor Author

I was under the impression that the platform should just be js, jvm, or native. But in any case, it sounds like an env var is the way to go.

@loewenheim loewenheim marked this pull request as ready for review August 27, 2024 14:20
@loewenheim loewenheim requested a review from mwarkentin August 27, 2024 14:20
@mwarkentin
Copy link
Member

@loewenheim ill try to get these rolled out everywhere tomorrow.

@loewenheim loewenheim merged commit f07e925 into master Aug 28, 2024
13 checks passed
@loewenheim loewenheim deleted the feat/platform-tag branch August 28, 2024 07:21
@mwarkentin
Copy link
Member

@loewenheim env vars have been configured on:

  • s4s
  • geico
  • goldmansachs
  • disney
  • ly
  • de
  • saas (us)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag symbolicator metrics with symbolicator_platform (or platform) tags
3 participants