Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(js): Handle webpack-internal prefix #1506

Merged
merged 1 commit into from
Aug 1, 2024
Merged

feat(js): Handle webpack-internal prefix #1506

merged 1 commit into from
Aug 1, 2024

Conversation

loewenheim
Copy link
Contributor

We have seen webpack paths with a prefix of webpack-internal, not just webpack. They should be handled analogously to those starting with webpack:.

@loewenheim loewenheim requested a review from armenzg August 1, 2024 14:56
@loewenheim loewenheim self-assigned this Aug 1, 2024
armenzg
armenzg approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

@loewenheim loewenheim merged commit 4533192 into master Aug 1, 2024
13 checks passed
@loewenheim loewenheim deleted the feat/webpack-internal branch August 1, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armenzg armenzg armenzg approved these changes

Assignees

@loewenheim loewenheim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loewenheim @armenzg