fix(js): Recognize more abs_paths as in-app #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original logic for deciding whether a JS frame should be in-app (seen [here](https://github.com/getsentry/sentry/blob/69ee8d0fcbff3494f2d2a6fb9fb59195fc49b575/src/sentry/lang/javascript/processor.py#L1573-L1603)) is quite convoluted and difficult to understand. The `is_in_app` function reproduces it faithfully, but with some refactoring. In any case, for webpack, only file names beginning with `./` would be considered as in-app, but judging from examples that's too strict. Therefore we change the logic for webpack as follows: A file name is considered _not_ in-app if either of these is true: * It starts with `~/` (according to the documentation in the original Python version, this means it's "coming from node_modules"). * It contains `/node_modules/` as a substring. Otherwise it's considered in-app.
jjbayer
approved these changes
Aug 1, 2024
Swatinem
approved these changes
Aug 1, 2024
armenzg
requested changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original logic for deciding whether a JS frame should be in-app (seen here) is quite convoluted and difficult to understand. The
is_in_appfunction reproduces it faithfully, but with some refactoring. In any case, for webpack, only file names beginning with./would be considered as in-app, but judging from examples that's too strict. Therefore we change the logic for webpack as follows: A file name is considered not in-app if either of these is true:~/(according to the documentation in the original Python version, this means it's "coming from node_modules")./node_modules/as a substring.Otherwise it's considered in-app.