Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove changelog nagger #1369

Merged
merged 2 commits into from
Feb 12, 2024
Merged

ci: Remove changelog nagger #1369

merged 2 commits into from
Feb 12, 2024

Conversation

loewenheim
Copy link
Contributor

We think this check causes far more headaches than it cures, particularly if we want to automate stuff with e.g. dependabot.

For the last time:
#skip-changelog

@loewenheim loewenheim self-assigned this Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (477d496) 75.89% compared to head (0f3c937) 75.75%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1369      +/-   ##
==========================================
- Coverage   75.89%   75.75%   -0.14%     
==========================================
  Files          99      101       +2     
  Lines       14766    14946     +180     
==========================================
+ Hits        11206    11322     +116     
- Misses       3560     3624      +64     

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also remove the dangerfile as well as that would be unused then :-)

@loewenheim
Copy link
Contributor Author

you can also remove the dangerfile as well as that would be unused then :-)

Missed that, thanks

@loewenheim loewenheim enabled auto-merge (squash) February 7, 2024 12:58
@loewenheim loewenheim merged commit b94d783 into master Feb 12, 2024
13 checks passed
@loewenheim loewenheim deleted the ci/remove-changelog-check branch February 12, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants