Avoid using moka in the SymbolProvider
#1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profiling has shown that `moka` might be a bit overkill for the `SymbolProvider`. The `SymbolProvider` is never used for long term caching, but only as a short term `HashMap`. This removed `moka` from this code path, and also avoids a bunch of Clones and other work from the `process_minidump` flow.
Swatinem
force-pushed
the
swatinem/symbolprovider-nomoka
branch
from
b69042c to
73dacd2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1356 +/- ##
==========================================
+ Coverage 75.88% 75.93% +0.04%
==========================================
Files 99 99
Lines 14764 14791 +27
==========================================
+ Hits 11204 11231 +27
Misses 3560 3560 |
loewenheim
reviewed
Jan 31, 2024
crates/symbolicator-native/src/symbolication/process_minidump.rs
Outdated
Show resolved
Hide resolved
crates/symbolicator-native/src/symbolication/process_minidump.rs
Outdated
Show resolved
Hide resolved
loewenheim
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling has shown that
mokamight be a bit overkill for theSymbolProvider. TheSymbolProvideris never used for long term caching, but only as a short termHashMap. This removedmokafrom this code path, and also avoids a bunch of Clones and other work from theprocess_minidumpflow.Looks like a ~10% win
#skip-changelog