Ingest metrics with Sentry as well #1351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
force-pushed
the
swatinem/sentry-metrics
branch
from
cd62655 to
0d516d1
Compare
Swatinem
force-pushed
the
swatinem/sentry-metrics
branch
2 times, most recently
from
805b729 to
4d321c1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1351 +/- ##
==========================================
- Coverage 76.09% 76.06% -0.03%
==========================================
Files 101 100 -1
Lines 15262 14851 -411
==========================================
- Hits 11613 11297 -316
+ Misses 3649 3554 -95 |
Swatinem
force-pushed
the
swatinem/sentry-metrics
branch
from
4d321c1 to
0a9804c
Compare
loewenheim
approved these changes
Mar 13, 2024
Comment on lines
23
to
25
| let sink = UdpMetricSink::from(&addrs[..], socket).unwrap(); | ||
| let mut builder = StatsdClient::builder(prefix, sink); | ||
| let udp_sink = BufferedUdpMetricSink::from(&addrs[..], socket).unwrap(); | ||
| let queuing_sink = QueuingMetricSink::from(udp_sink); | ||
| let mut builder = StatsdClient::builder(prefix, queuing_sink); |
There was a problem hiding this comment.
This is the same change as in #1360, right?
There was a problem hiding this comment.
I think you are looking at on old diff. I pretty much just rebased this far enough so that I can capture a profile for demonstration purposes :-D
|
#1408 is now hooked up to the aggregator and sends Sentry metrics from the final aggregator thread. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we often
&X.to_string()forcadencesake because it takes a&'a str, and now we have to.to_string()a shitton more because Sentry wants aCow<'static, str>makes me die inside :-(The overhead of using Sentry metrics looks like a ~2x-10x reduction in throughput:
#skip-changelog