Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using shared cache for internally stored files #1320

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Oct 6, 2023

It is a bit wasteful to look up our internally hosted Symbols on GCS, just to store them on GCS again in the form of the shared cache.
We can avoid doing this needless duplication of roundtrips and storage.

We could also avoid using the shared cache for objects and bundle indexes that are stored in Sentry, but here the benefits are less clear, as avoiding shared cache would mean going through the Python abstraction. Right now, we rather waste a bit of storage in favor of avoiding Python.

These tradeoffs could potentially change in the future with a more efficient filestore implementation though.

#skip-changelog

@Swatinem Swatinem self-assigned this Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #1320 (dd8e839) into master (d8704ed) will increase coverage by 0.01%.
The diff coverage is 90.32%.

@@            Coverage Diff             @@
##           master    #1320      +/-   ##
==========================================
+ Coverage   75.68%   75.70%   +0.01%     
==========================================
  Files          94       94              
  Lines       14701    14727      +26     
==========================================
+ Hits        11127    11149      +22     
- Misses       3574     3578       +4     

@Swatinem Swatinem merged commit 8ce62ca into master Oct 6, 2023
14 checks passed
@Swatinem Swatinem deleted the swatinem/use-shared-cache branch October 6, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants