Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GoCD Jsonnet library #1312

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Conversation

mattgauntseo-sentry
Copy link
Contributor

This fixes an issue in rollbacks that can cause multiple deploys of the same commit. Now rollbacks have a final manual stage that unpauses and unlocks the pipelines once an incident is complete.

For the curious: The I removed the pipeline-complete stage in a previous version, this caused pipelines to be unlocked after a rollback is complete (a problem folks were running into), however this meant the final stage in the deploy was the stage the rollback re-ran. Since this final stage was run, it triggered the downstream pipeline to run which was unintentional.

#skip-changelog

@mattgauntseo-sentry mattgauntseo-sentry requested a review from a team September 28, 2023 17:51
@mattgauntseo-sentry mattgauntseo-sentry marked this pull request as ready for review September 28, 2023 17:51
@mattgauntseo-sentry mattgauntseo-sentry merged commit 30a69d6 into master Sep 29, 2023
15 checks passed
@mattgauntseo-sentry mattgauntseo-sentry deleted the mgs-update-gocd-231 branch September 29, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants