-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Return "scraping attempts" from JS symbolication #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions for snapshot changesSentry runs a symbolicator integration test suite located at Follow these steps to update snapshots in Sentry:
|
Swatinem
approved these changes
Sep 29, 2023
Codecov Report
@@ Coverage Diff @@
## master #1311 +/- ##
==========================================
- Coverage 75.75% 75.68% -0.08%
==========================================
Files 91 91
Lines 14615 14691 +76
==========================================
+ Hits 11072 11119 +47
- Misses 3543 3572 +29 |
loewenheim
added a commit
to getsentry/sentry
that referenced
this pull request
Oct 4, 2023
This appends the `scraping_attempts` sent by Symbolicator since getsentry/symbolicator#1311 to an event's data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This records the outcome of every attempt to scrape a JS source or sourcemap file from the web and returns these attempts in
CompletedJsSymbolicationResponse
.It also records a "not attempted" attempt whenever a file is found via another method.
#skip-changelog