Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence BundleIndex error #1308

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Silence BundleIndex error #1308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions crates/symbolicator-service/src/services/sourcemap_lookup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,14 +810,20 @@ impl ArtifactFetcher {
}
}

// If we get to this point, it means that the `BundleIndex` lied to us
tracing::error!(
?key,
?lookup_key,
?index_id,
?bundle_id,
"Indexed file not found in `ArtifactBundle`"
);
// If we get to this point, it means that the `BundleIndex` lied to us.
// However, we do not expect to always have a SourceMap corresponding to a non-minified
// file with a DebugId.
let hit_is_optional = matches!(lookup_key, IndexLookupKey::DebugId(..))
&& key.as_type() == SourceFileType::SourceMap;
if !hit_is_optional {
tracing::error!(
?key,
?lookup_key,
?index_id,
?bundle_id,
"Indexed file not found in `ArtifactBundle`"
);
}

None
}
Expand Down
Loading