Backfill missing DebugId from CFI Cache #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen customer minidumps that do not have proper DebugIds in them. However, there is a valid CodeId, which would allow the executable to be fetched from an external SSQP symbol server. We transform this executable to a CfiCache, which in theory could have a breakpad `MODULE` entry. Though in practice it does not (yet), as we never output one. This would allow backfilling the missing DebugID in the minidump with the one found in the executable that we use to generate the CfiCache.
Codecov Report
@@ Coverage Diff @@
## master #1305 +/- ##
==========================================
- Coverage 75.85% 75.77% -0.09%
==========================================
Files 91 91
Lines 14594 14617 +23
==========================================
+ Hits 11071 11076 +5
- Misses 3523 3541 +18 |
loewenheim
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen customer minidumps that do not have proper DebugIds in them. However, there is a valid CodeId, which would allow the executable to be fetched from an external SSQP symbol server. We transform this executable to a CfiCache, which in theory could have a breakpad
MODULEentry. Though in practice it does not (yet), as we never output one.This would allow backfilling the missing DebugID in the minidump with the one found in the executable that we use to generate the CfiCache.
#skip-changelog