fix: Don't log entire S3 error as part of the message (#1542)

getsentry · Oct 23, 2024 · a56852b · a56852b
1 parent 6f6cf85
commit a56852b
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/crates/symbolicator-service/src/download/s3.rs b/crates/symbolicator-service/src/download/s3.rs
@@ -130,8 +130,7 @@ impl S3Downloader {
                         // of these in production and figure out what we actually get here
                         tracing::error!(
                             error = &err as &dyn std::error::Error,
-                            "S3 request timed out: {:?}",
-                            err
+                            "S3 request timed out",
                         );
                         return Err(CacheError::Timeout(Duration::ZERO));
                     }
@@ -169,7 +168,7 @@ impl S3Downloader {
                         tracing::error!(
                             error = &err as &dyn std::error::Error,
                             "S3 request failed: {:?}",
-                            err
+                            err.code(),
                         );
                         let details = err.to_string();
                         Err(CacheError::DownloadError(details))
@@ -179,7 +178,7 @@ impl S3Downloader {
         };
 
         if response.content_length == Some(0) {
-            tracing::debug!("Empty response from s3:{}{}", &bucket, &key);
+            tracing::debug!(bucket, key, "Empty response from s3");
             return Err(CacheError::NotFound);
         }