Skip to content

Commit

Permalink
Downgrade moka (#1310)
Browse files Browse the repository at this point in the history
The recent dependency update introduced a memory leak, which might be related to the `moka` update, so try downgrading that.
  • Loading branch information
Swatinem authored Sep 27, 2023
1 parent 519f4dd commit 7ce9f63
Show file tree
Hide file tree
Showing 3 changed files with 137 additions and 15 deletions.
148 changes: 135 additions & 13 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/symbolicator-service/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ lazy_static = "1.4.0"
minidump = "0.18.0"
minidump-processor = "0.18.0"
minidump-unwind = "0.18.0"
moka = { version = "0.12.0", features = ["future", "sync"] }
moka = { version = "0.11.0", features = ["future", "sync"] }
once_cell = "1.17.1"
parking_lot = "0.12.0"
rand = "0.8.5"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ async fn stackwalk(

let mut obj_info = object_info_from_minidump_module(ty, module);

obj_info.unwind_status = Some(match provider.cficaches.get(&key).await {
obj_info.unwind_status = Some(match provider.cficaches.get(&key) {
None => ObjectFileStatus::Unused,
Some(cfi_module) => {
obj_info.features.merge(cfi_module.features);
Expand Down

0 comments on commit 7ce9f63

Please sign in to comment.