Skip to content

Commit

Permalink
Remove scrape_js_file transaction
Browse files Browse the repository at this point in the history
We added this at one point to look at the `host`, but I doubt noone ever did this,
or not in any recent history.

Overhead from this should be negligible, but no code is still faster than fast code :-D
  • Loading branch information
Swatinem committed Feb 2, 2024
1 parent 8218752 commit 781905e
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions crates/symbolicator-js/src/lookup.rs
Original file line number Diff line number Diff line change
Expand Up @@ -904,18 +904,6 @@ impl ArtifactFetcher {

self.metrics.scraped_files += 1;

let span = sentry::configure_scope(|scope| scope.get_span());
let ctx = sentry::TransactionContext::continue_from_span(
"scrape_js_file",
"scrape_js_file",
span,
);
let transaction = sentry::start_transaction(ctx);
sentry::configure_scope(|scope| {
scope.set_span(Some(transaction.clone().into()));
scope.set_tag("host", host_string);
});

// We add a hash with a timestamp to the `url` to make sure that we are busting caches
// that are based on the `uri`.
let timestamp = SystemTime::now()
Expand All @@ -941,7 +929,6 @@ impl ArtifactFetcher {
.fetch_file(&self.scope, remote_file, false)
.await;

transaction.finish();
let entry = match scraped_file {
Ok(contents) => {
self.metrics.record_file_scraped(key.as_type());
Expand Down

0 comments on commit 781905e

Please sign in to comment.