Skip to content

Commit

Permalink
Increase percentage of sampled transactions (#1376)
Browse files Browse the repository at this point in the history
  • Loading branch information
Swatinem authored Feb 16, 2024
1 parent 813057c commit 4ae4745
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions crates/symbolicator/src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,16 @@ pub fn execute() -> Result<()> {
if Some(true) == ctx.sampled() {
1.0
} else if ctx.operation() != "http.server" {
// Symbolicator receives ~200 rps right now,
// with ~20 sampled transactions per minute,
// which comes to an effective sampling rate of `1/600` (~0.0016).
// Lets crank that up to `0.02`, which would give us ~4 rps,
// or ~240 transactions per minute.
// Symbolicator receives at peak:
// - ~3_000 `symbolicate_js`,
// - ~800 `symbolicater`, and
// - ~40 `minidump_stackwalk` requests per second.
//
// round that up to ~4_000 total requests per second, with a 5% sample rate,
// we end up with ~200 sampled transactions per second, or ~12_000 per minute.
// We only do this for the "real" transactions and not the http frontend that
// just spawns these computations.
0.02
0.05
} else {
0.0
}
Expand Down

0 comments on commit 4ae4745

Please sign in to comment.