Skip to content

Commit

Permalink
Create a tracing layer doing JSON output and Sentry at once
Browse files Browse the repository at this point in the history
Using composition to chain the JSON output and the Sentry layer means that both layers are capturing span attributes, duplicating that work.

This pretty much copy-pasted the code of both these layers and combines them, thus avoiding doing all the `SpanAttribute` capturing twice.
  • Loading branch information
Swatinem committed Feb 20, 2024
1 parent a373238 commit 2bc0c4f
Show file tree
Hide file tree
Showing 3 changed files with 443 additions and 16 deletions.
3 changes: 3 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions crates/symbolicator-service/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,11 @@ symbolic = { version = "12.7.1", features = ["cfi", "common-serde", "debuginfo",
symbolicator-sources = { path = "../symbolicator-sources" }
tempfile = "3.2.0"
thiserror = "1.0.31"
time = { version = "0.3.34", features = ["serde", "formatting"] }
tokio = { version = "1.24.2", features = ["rt", "macros", "fs"] }
tokio-util = { version = "0.7.1", features = ["io"] }
tracing = "0.1.34"
tracing-serde = "0.1.3"
tracing-subscriber = { version = "0.3.17", features = ["env-filter", "time", "json"] }
url = { version = "2.2.0", features = ["serde"] }
uuid = { version = "1.0.0", features = ["v4", "serde"] }
Expand Down
Loading

0 comments on commit 2bc0c4f

Please sign in to comment.