fix(symcache): Use saturating addition in writer #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition wraps in release mode. For large line size values, this resulted in ranges whose end was before their start, which caused us to skip a function's inlinees in some cases. Instead of using bare addition on `u64` and casting to `u32` at the end, we now use saturating addition on `u32` directly.
jjbayer
approved these changes
Dec 18, 2024
Litarnus
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition wraps in release mode. For large line size values, this resulted in ranges whose end was before their start, which caused us to skip a function's inlinees in some cases.
Instead of using bare addition on
u64and casting tou32at the end, we now use saturating addition onu32directly.