fix(cfi): Skip u64::MAX FDEs when converting DWARF #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olksdr
reviewed
Sep 17, 2024
| if fde.initial_address() == u64::MAX { | ||
| return Ok(()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Is it possible to add test for this?
There was a problem hiding this comment.
Unfortunately I can't see how—our only example is a debug file from Riot, and we can't put that on GH.
tobias-wilfert
approved these changes
Sep 17, 2024
|
Presumably even if the address overflow error in |
Not sure, but I've verified that each of those entries hits one of the two problems. |
loewenheim
force-pushed
the
fix/invalid-fdes
branch
from
5d93a16 to
bf4ee12
Compare
Swatinem
approved these changes
Sep 17, 2024
loewenheim
added a commit
to getsentry/symbolicator
that referenced
this pull request
Sep 18, 2024
This pulls in getsentry/symbolic#868, allowing us to process some CFI in DWARF files that we previously rejected as broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen FDEs with an initial address of
u64::MAXin user-provided DWARF files. Such FDEs will invariably fail to process because of either an address overflow error ingimlior an underflow in thelengthcalculation in line 756. Therefore, we skip them immediately so we don't abort the processing of the entire file.