Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental symbolic-py pyo3/maturin crate #819

Closed
wants to merge 1 commit into from

Conversation

Swatinem
Copy link
Member

This is an attempt to replace the manual cabi/py wrapper with one built using pyo3 and maturin.

This is an attempt to replace the manual cabi/py wrapper with one built using pyo3 and maturin.
@Swatinem Swatinem self-assigned this Oct 24, 2023
@github-actions
Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add experimental symbolic-py pyo3/maturin crate ([#819](https://github.com/getsentry/symbolic/pull/819))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against faea90d

@daddycocoaman
Copy link

Hi,

Just curious but does this effort mean that symbolic is expected to maintain Python/C API support with all the necessary functions exposed?

@Swatinem
Copy link
Member Author

Swatinem commented Nov 2, 2023

No, on the contrary.

This is just an early experiment, which eventually feeds into getsentry/rfcs#119.
The goal would be to completely deprecate the python bindings to symbolic directly, and rather have sentry specific python bindings that have no SemVer guarantees whatsoever.

The python bindings in symbolic itself are:

  • completely outdated (binding-wise)
  • expose only a subset of symbolic functionality on the one hand and
  • expose more than the symbolic rust crates (things like proguard)
  • are a nightmare to maintain, and cause frequent headaches to release to pypi

All that being said, I would consider the symbolic python bindings as deprecated, and we will completely remove them at one point or another in a future semver-major release.

@daddycocoaman
Copy link

Ah, ok. Sorry to hear. I just recently came across this repo and had a really great use case for it in Python but I guess I'll figure it out. Thanks.

@Swatinem
Copy link
Member Author

Swatinem commented Nov 2, 2023

As this PR has shown, creating python bindings with maturin/pyo3 is really straight forward, so you can just pick whatever functionality want from the symbolic Rust crate and create your own bindings directly if you really want that.

@Swatinem
Copy link
Member Author

This was now released as https://github.com/getsentry/ophio

@Swatinem Swatinem closed this Jan 30, 2024
@Swatinem Swatinem deleted the swatinem/maturin branch January 30, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants