ci: provide arm64 image build #6825
Conversation
| runs-on: |- | ||
| ${{fromJson('{ | ||
| "amd64": "ubuntu-22.04", | ||
| "arm64": "ubuntu-22.04-arm" | ||
| }')[matrix.arch] }} |
There was a problem hiding this comment.
if you want to see some real crazy usage of fromJson, check out what cargo-dist does. it seems that one can generate matrices programmatically, put them into job output and then reference them here.
There was a problem hiding this comment.
Hey, the credits goes to @Dav1dde lol
There was a problem hiding this comment.
Just to note, this is absolutely not necessary here, I did it this way to not have the runner show up in the generated job name in CI.
There was a problem hiding this comment.
Just to note, this is absolutely not necessary here, I did it this way to not have the runner show up in the generated job name in CI.
No no, it's useful. We need to use the correct GHA runner with the corresponding arch name (amd64/arm64)
|
Yeah, I cannot really review this. Will leave to @untitaker |
.github/workflows/image.yml
Outdated
| "ghcr.io/getsentry/snuba:amd64-${{ github.sha }}" | ||
|
|
||
| - name: Assemble Latest Image | ||
| if: github.ref_name == 'main' |
There was a problem hiding this comment.
our branch is called master (still)
.github/workflows/image.yml
Outdated
| "arm64": "ubuntu-22.04-arm" | ||
| }')[matrix.arch] }} | ||
| env: | ||
| IMG_VERSIONED: ghcr.io/getsentry/vroom:${{ matrix.arch }}-${{ github.sha }} |
There was a problem hiding this comment.
copypaste error, we're not vroom
| - name: Assemble Latest Image | ||
| if: github.ref_name == 'main' | ||
| run: | | ||
| docker buildx imagetools create -t "ghcr.io/getsentry/snuba:latest" \ |
There was a problem hiding this comment.
are you 100% sure that imagetools create pushes to the registry? though i don't see a --push flag avail
There was a problem hiding this comment.
Yes it does, this is taken from Symbolicator and that's how it pushes its images.
Effort for getsentry/self-hosted#1585
Build result for arm64: https://github.com/getsentry/snuba/actions/runs/12960880084/job/36155350053?pr=6825
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.