fix(eap-api): string equality ignoring case

getsentry · Jan 27, 2025 · ac66e82 · ac66e82
1 parent 07d135c
commit ac66e82
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/snuba/web/rpc/common/common.py b/snuba/web/rpc/common/common.py
@@ -291,7 +291,11 @@ def trace_item_filters_to_expression(item_filter: TraceItemFilter) -> Expression
             case "val_bool":
                 v_expression: Expression = literal(v.val_bool)
             case "val_str":
-                v_expression = literal(v.val_str)
+                v_expression = (
+                    literal(v.val_str.lower())
+                    if item_filter.comparison_filter.ignore_case
+                    else literal(v.val_str)
+                )
             case "val_float":
                 v_expression = literal(v.val_float)
             case "val_double":

diff --git a/snuba/web/rpc/v1/resolvers/R_ourlogs/common/trace_item_filters_to_expression.py b/snuba/web/rpc/v1/resolvers/R_ourlogs/common/trace_item_filters_to_expression.py
@@ -62,7 +62,11 @@ def trace_item_filters_to_expression(item_filter: TraceItemFilter) -> Expression
             case "val_bool":
                 v_expression: Expression = literal(v.val_bool)
             case "val_str":
-                v_expression = literal(v.val_str)
+                v_expression = (
+                    literal(v.val_str.lower())
+                    if item_filter.comparison_filter.ignore_case
+                    else literal(v.val_str)
+                )
             case "val_float":
                 v_expression = literal(v.val_float)
             case "val_int":

diff --git a/snuba/web/rpc/v1/resolvers/R_uptime_checks/common/common.py b/snuba/web/rpc/v1/resolvers/R_uptime_checks/common/common.py
@@ -244,7 +244,11 @@ def trace_item_filters_to_expression(item_filter: TraceItemFilter) -> Expression
             case "val_bool":
                 v_expression: Expression = literal(v.val_bool)
             case "val_str":
-                v_expression = literal(v.val_str)
+                v_expression = (
+                    literal(v.val_str.lower())
+                    if item_filter.comparison_filter.ignore_case
+                    else literal(v.val_str)
+                )
             case "val_float":
                 v_expression = literal(v.val_float)
             case "val_double":