Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): Support offset pagination in table RPC #84020

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

Zylphrex
Copy link
Member

This was being ignored previously.

Depends on getsentry/snuba#6816

This was being ignored previously.

Depends on getsentry/snuba#6816
@Zylphrex Zylphrex requested a review from a team as a code owner January 24, 2025 19:37
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #84020    +/-   ##
========================================
  Coverage   87.55%   87.55%            
========================================
  Files        9546     9546            
  Lines      541353   541148   -205     
  Branches    21304    21298     -6     
========================================
- Hits       473977   473825   -152     
+ Misses      67021    66968    -53     
  Partials      355      355            

@Zylphrex Zylphrex merged commit 2112881 into master Jan 24, 2025
49 checks passed
@Zylphrex Zylphrex deleted the txiao/fix/support-offset-pagination-in-table-rpc branch January 24, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants