Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: fix typing for sentry_plugins.bitbucket.client #84008

Merged
merged 1 commit into from
Jan 24, 2025
+5 −2
Merged

ref: fix typing for sentry_plugins.bitbucket.client #84008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,6 @@ module = [
"sentry.web.frontend.base",
"sentry.web.frontend.react_page",
"sentry.web.frontend.shared_group_details",
"sentry_plugins.bitbucket.client",
"sentry_plugins.bitbucket.mixins",
"sentry_plugins.github.plugin",
"sentry_plugins.jira.plugin",
Expand Down
6 changes: 5 additions & 1 deletion src/sentry_plugins/bitbucket/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
from __future__ import annotations

from typing import Any

from django.conf import settings
from requests_oauthlib import OAuth1

Expand Down Expand Up @@ -78,7 +82,7 @@ def compare_commits(self, repo, start_sha, end_sha):
# where start_sha is oldest and end_sha is most recent
# see
# https://developer.atlassian.com/bitbucket/api/2/reference/resource/repositories/%7Busername%7D/%7Brepo_slug%7D/commits/%7Brevision%7D
commits = []
commits: list[dict[str, Any]] = []
done = False

url = f"/2.0/repositories/{repo}/commits/{end_sha}"
Expand Down
Loading