drop(integration): Always fetch max number of pages #83984
+16
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is very easy to write code and not pass the parameter, thus, we won't get the whole set of repositories. This will cause the calls to be slower for customers with thousands of repos, however, it will be more accurate. We still have `self.page_number_limit` to stop the requests after 50 page fetches (5,000 repositories).
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Jan 24, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83984 +/- ##
===========================================
+ Coverage 33.07% 87.56% +54.49%
===========================================
Files 8079 9545 +1466
Lines 450123 541175 +91052
Branches 21290 21274 -16
===========================================
+ Hits 148861 473870 +325009
+ Misses 300907 66950 -233957
Partials 355 355 |
armenzg
commented
Jan 24, 2025
| repos = self.get_with_pagination( | ||
| "/installation/repositories", | ||
| response_key="repositories", | ||
| page_number_limit=self.page_number_limit if fetch_max_pages else 1, |
There was a problem hiding this comment.
self.page_number_limit is the default, thus, we don't need to pass it anymore.
armenzg
commented
Jan 24, 2025
| response_key="repositories", | ||
| page_number_limit=self.page_number_limit if fetch_max_pages else 1, | ||
| ) | ||
| return [repo for repo in repos if not repo.get("archived")] |
There was a problem hiding this comment.
This is now handled by the callers:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very easy to write code and not pass the parameter, thus, we won't get the whole set of repositories.
This will cause the calls to be slower for customers with thousands of repositories, however, it will be more accurate.
We still have
self.page_number_limitto stop the requests after 50-page fetches (5,000 repositories).