Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ourlogs): Implement the initial version of the logs tab #83962

Merged
merged 5 commits into from
Jan 24, 2025
Merged

feat(ourlogs): Implement the initial version of the logs tab #83962

merged 5 commits into from
Jan 24, 2025

Conversation

colin-sentry
Copy link
Member

@colin-sentry colin-sentry commented Jan 23, 2025 •
edited
Loading

Screenshot, data pulled end-to-end from clickhouse. Search also works.

Screenshot 2025-01-24 at 3 42 04 PM

@colin-sentry colin-sentry requested review from a team as code owners January 23, 2025 22:01
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Jan 23, 2025
@colin-sentry colin-sentry removed the Scope: Backend Automatically applied to PRs that change backend components label Jan 24, 2025
@getsentry getsentry deleted a comment from github-actions bot Jan 24, 2025
@getsentry getsentry deleted a comment from codecov bot Jan 24, 2025
@colin-sentry colin-sentry requested a review from a team as a code owner January 24, 2025 20:41
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 27.54kB (0.08%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 33.38MB 27.54kB (0.08%) ⬆️

Zylphrex
Zylphrex approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@Zylphrex Zylphrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big issues here but I would consider moving to consistent public names for these fields soon so we don't end up with the internal names everywhere.

static/app/views/explore/logs/index.tsx Outdated Show resolved Hide resolved
static/app/views/explore/logs/index.tsx Show resolved Hide resolved
static/app/views/explore/logs/logsTab.tsx Outdated Show resolved Hide resolved
static/app/views/explore/logs/logsTable.tsx Outdated Show resolved Hide resolved
static/app/views/explore/logs/logsTable.tsx Outdated Show resolved Hide resolved
static/app/views/explore/logs/logsTable.tsx Show resolved Hide resolved
@colin-sentry colin-sentry enabled auto-merge (squash) January 24, 2025 23:37
@colin-sentry colin-sentry merged commit fd52e4c into master Jan 24, 2025
42 checks passed
@colin-sentry colin-sentry deleted the logs_tab_content branch January 24, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zylphrex Zylphrex Zylphrex approved these changes

@k-fish k-fish Awaiting requested review from k-fish

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colin-sentry @Zylphrex