feat(integrations): Unify get_repositories signature #83921
Merged
+47
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Jan 23, 2025
| @@ -381,6 +381,7 @@ module = [ | |||
| "sentry.integrations.services.*", | |||
| "sentry.integrations.slack.threads.*", | |||
| "sentry.integrations.slack.views.*", | |||
| "sentry.integrations.source_code_management.repository", | |||
There was a problem hiding this comment.
This is the list of modules with stronger typing.
| @@ -3,7 +3,7 @@ | |||
| import logging | |||
| from collections.abc import Mapping, Sequence | |||
| from datetime import datetime | |||
| from typing import Any, cast | |||
There was a problem hiding this comment.
Using cast is a bad practice, thus, removing it.
| @@ -493,26 +493,6 @@ def _populate_tree( | |||
| ) | |||
| return RepoTree(Repo(full_name, branch), repo_files) | |||
|
|
|||
| def get_repositories(self, fetch_max_pages: bool = False) -> Sequence[Any]: | |||
There was a problem hiding this comment.
I'm integrating this into github/integration.py.
| return [ | ||
| { | ||
| "name": i["name"], | ||
| "identifier": i["full_name"], | ||
| "default_branch": i.get("default_branch"), | ||
| } | ||
| for i in self.get_client().get_repositories(fetch_max_pages) |
There was a problem hiding this comment.
The added code all comes from the get_repositories I delete:
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83921 +/- ##
==========================================
+ Coverage 87.55% 87.66% +0.11%
==========================================
Files 9542 9536 -6
Lines 540927 546135 +5208
Branches 21282 21206 -76
==========================================
+ Hits 473623 478786 +5163
- Misses 66949 66983 +34
- Partials 355 366 +11 |
|
I need to fix the tests first. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies the signature of
get_repositoriesof all SCM integrations.It also consolidates
get_repositoriesfor GitHub.