-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metric-issue): Display open periods table instead of all events #83852
Merged
+135
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Automatically applied to PRs that change frontend components
label
Jan 22, 2025
snigdhas
force-pushed
the
snigdha/all-open-periods
branch
from
January 22, 2025 20:47
3d6dc5b
to
6634e87
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83852 +/- ##
==========================================
- Coverage 87.63% 87.57% -0.06%
==========================================
Files 9517 9405 -112
Lines 542188 536436 -5752
Branches 21228 21155 -73
==========================================
- Hits 475128 469775 -5353
+ Misses 66694 66313 -381
+ Partials 366 348 -18 |
scttcper
reviewed
Jan 23, 2025
scttcper
reviewed
Jan 23, 2025
scttcper
reviewed
Jan 23, 2025
scttcper
reviewed
Jan 23, 2025
scttcper
reviewed
Jan 23, 2025
scttcper
reviewed
Jan 23, 2025
Bundle ReportChanges will increase total bundle size by 913.71kB (2.82%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
scttcper
reviewed
Jan 24, 2025
scttcper
approved these changes
Jan 24, 2025
scttcper
reviewed
Jan 24, 2025
Co-authored-by: Scott Cooper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the 'All Events' tab to show open periods, controlled by the issue type config. This is an in between state with no pagination. Once the backend PR (#83797) is merged, this can be updated to match the pagination and sorting behavior of the all events table.