lint(eslint): Enable no-extra-non-null-assertion and auto-fix violations #83786
+84
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
commented
Jan 21, 2025
| @@ -344,7 +344,7 @@ export default typescript.config([ | |||
| ...react.configs.flat.recommended.rules, | |||
| ...react.configs.flat['jsx-runtime'].rules, | |||
| 'react/display-name': 'off', // TODO(ryan953): Fix violations and delete this line | |||
| 'react/no-unescaped-entities': 'off', // TODO(ryan953): Fix violations and delete this line | |||
| 'react/no-unescaped-entities': 'off', | |||
There was a problem hiding this comment.
This isn't going to happen. I tried and it's not worth it right now: #83511
ryan953
commented
Jan 21, 2025
| @@ -418,8 +418,7 @@ export default typescript.config([ | |||
| '@typescript-eslint/ban-ts-comment': 'off', // TODO(ryan953): Fix violations and delete this line | |||
| '@typescript-eslint/no-array-constructor': 'off', // TODO(ryan953): Fix violations and delete this line | |||
| '@typescript-eslint/no-empty-object-type': 'off', // TODO(ryan953): Fix violations and delete this line | |||
| '@typescript-eslint/no-explicit-any': 'off', // TODO(ryan953): Fix violations and delete this line | |||
| '@typescript-eslint/no-extra-non-null-assertion': 'off', // TODO(ryan953): Fix violations and delete this line | |||
| '@typescript-eslint/no-explicit-any': 'off', | |||
There was a problem hiding this comment.
no-explicit-any isn't going to happen.
ryan953
commented
Jan 21, 2025
| @@ -142,11 +142,11 @@ export const MetricChart = memo( | |||
| } | |||
| }); | |||
|
|
|||
| const bucketSize = series[0]!?.data[1]!?.name - series[0]!?.data[0]!?.name; | |||
There was a problem hiding this comment.
This is a good example where a manual fix was needed...
Before we had ! next to each of the optional fields, chained all the way down.
Now we have one ! at the end of the chain.
ryan953
commented
Jan 21, 2025
| @@ -668,7 +668,7 @@ describe('WaterfallModel', () => { | |||
|
|
|||
| expected[1] = { | |||
| type: 'out_of_view', | |||
| span: fullWaterfall[1]!!.span, | |||
There was a problem hiding this comment.
Here's an example of the automation fixing some earlier automation.
ryan953
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two kinda of fixes in here
Auto fixes to remove double
!!:and manual fixes to move many
!to the end of chains: