ref(dashboards): Extract WidgetLayout from WidgetFrame
#83760
Merged
+423
−229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A layout-only container for things that might go into a widget.
…dashboards/widget-layout
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 32.97kB (0.1%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
This is too useful to continually ignore forever.
narsaynorath
approved these changes
Jan 22, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
`WidgetLayout` is the innards of `WidgetFrame,` split up into separate components, exported, and documented. This makes it possible to create your own custom widget and have it look pretty standard. Good for exception cases like Explore that would blow up the "standard" widgets. This is almost a pure refactor, just moving some components around. The only difference is adding first-class support for widget captions. No visual changes here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WidgetLayoutis the innards ofWidgetFrame,split up into separate components, exported, and documented.This makes it possible to create your own custom widget and have it look pretty standard. Good for exception cases like Explore that would blow up the "standard" widgets. This is almost a pure refactor, just moving some components around. The only difference is adding first-class support for widget captions. No visual changes here!
e.g.,
