-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags): Update issues search box to search for feature flags #83639
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83639 +/- ##
==========================================
+ Coverage 87.52% 87.71% +0.19%
==========================================
Files 9543 9528 -15
Lines 541004 549564 +8560
Branches 21290 21181 -109
==========================================
+ Hits 473502 482058 +8556
+ Misses 67147 67140 -7
- Partials 355 366 +11 |
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good!
@@ -628,3 +628,11 @@ def register_temporary_features(manager: FeatureManager): | |||
FeatureHandlerStrategy.FLAGPOLE, | |||
api_expose=True, | |||
) | |||
|
|||
# Feature Flags Features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mind moving the FF flags above this to under this section as well? (e.g. i see feature-flag-cta
, feature-flag-audit-log
, feature-flag-ui
)
Rewrite tag queries to search for flags as well. Update autocomplete endpoint to search for flags if the query parameter is given.
Closes: https://github.com/getsentry/team-replay/issues/521