Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): Update issues search box to search for feature flags #83639

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Jan 17, 2025

Rewrite tag queries to search for flags as well. Update autocomplete endpoint to search for flags if the query parameter is given.

Closes: https://github.com/getsentry/team-replay/issues/521

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 99.29577% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/search/snuba/executors.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #83639      +/-   ##
==========================================
+ Coverage   87.52%   87.71%   +0.19%     
==========================================
  Files        9543     9528      -15     
  Lines      541004   549564    +8560     
  Branches    21290    21181     -109     
==========================================
+ Hits       473502   482058    +8556     
+ Misses      67147    67140       -7     
- Partials      355      366      +11     

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 22, 2025
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@cmanallen cmanallen marked this pull request as ready for review January 24, 2025 16:14
@cmanallen cmanallen requested review from a team as code owners January 24, 2025 16:14
Copy link
Member

@aliu39 aliu39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good!

src/sentry/features/temporary.py Show resolved Hide resolved
src/sentry/tagstore/snuba/backend.py Show resolved Hide resolved
src/sentry/search/snuba/executors.py Outdated Show resolved Hide resolved
src/sentry/search/snuba/executors.py Outdated Show resolved Hide resolved
src/sentry/tagstore/snuba/backend.py Show resolved Hide resolved
@@ -628,3 +628,11 @@ def register_temporary_features(manager: FeatureManager):
FeatureHandlerStrategy.FLAGPOLE,
api_expose=True,
)

# Feature Flags Features.
Copy link
Member

@michellewzhang michellewzhang Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind moving the FF flags above this to under this section as well? (e.g. i see feature-flag-cta, feature-flag-audit-log, feature-flag-ui)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants