-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(flags): allow launchdarkly member to be null #83054
Conversation
This PR has a migration; here is the generated SQL for --
-- Alter field created_by on flagauditlogmodel
--
ALTER TABLE "flags_audit_log" ALTER COLUMN "created_by" DROP NOT NULL;
--
-- Alter field created_by_type on flagauditlogmodel
--
ALTER TABLE "flags_audit_log" ALTER COLUMN "created_by_type" DROP NOT NULL; |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83054 +/- ##
===========================================
+ Coverage 33.13% 87.59% +54.46%
===========================================
Files 7988 9429 +1441
Lines 446878 536264 +89386
Branches 21113 21063 -50
===========================================
+ Hits 148082 469757 +321675
+ Misses 298437 66147 -232290
- Partials 359 360 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job Michelle! Last item is to update the blueprint so clients know this field can be null now.
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Bundle ReportBundle size has no change ✅ |
) merge before #83054 it looks like we weren't using the `createdBy` or `createdByType` field anywhere
LaunchDarkly can have an undefined value for member in its payload, which means we have nothing to set in our
created_by
value in the audit log. However, thecreatedBy
column is currently required. This PR migrates the model to allow for null values for the created by and created by type.