Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Fix exports in Add to Dashboard modal #83046

Merged

Conversation

narsaynorath
Copy link
Member

@narsaynorath narsaynorath commented Jan 7, 2025

Exporting these files from the widgetCard/index.tsx file was causing the following error: Cannot access 'WidgetCardPanel' before initialization

This was from a circular import and the fix is to move these dependencies into their own files which don't rely on other imports that may trigger the issue.

@narsaynorath narsaynorath requested review from a team as code owners January 7, 2025 21:30
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 7, 2025
@narsaynorath narsaynorath force-pushed the nar/fix/dashboard-add-to-dashboard-flow-erroring branch from 653863a to 7510de2 Compare January 7, 2025 22:00
@narsaynorath narsaynorath merged commit af29b6c into master Jan 8, 2025
44 checks passed
@narsaynorath narsaynorath deleted the nar/fix/dashboard-add-to-dashboard-flow-erroring branch January 8, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants