Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: delete some dead methods from tsdb #83008

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

asottile-sentry
Copy link
Member

@asottile-sentry asottile-sentry commented Jan 7, 2025

no callers in getsentry or sentry

found via https://github.com/asottile/dead

@asottile-sentry asottile-sentry requested a review from a team January 7, 2025 17:50
@asottile-sentry asottile-sentry requested a review from a team as a code owner January 7, 2025 17:50
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 7, 2025
@asottile-sentry asottile-sentry force-pushed the asottile-some-dead-code-tsdb branch from 61df929 to a040135 Compare January 7, 2025 17:57
@asottile-sentry asottile-sentry requested a review from a team as a code owner January 7, 2025 17:57
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good to prune tsdb as much as possible

@asottile-sentry asottile-sentry enabled auto-merge (squash) January 7, 2025 18:19
@asottile-sentry asottile-sentry force-pushed the asottile-some-dead-code-tsdb branch from 3453bcf to 85b1cca Compare January 7, 2025 18:34
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #83008      +/-   ##
==========================================
- Coverage   87.56%   87.56%   -0.01%     
==========================================
  Files        9419     9419              
  Lines      536760   536603     -157     
  Branches    21115    21115              
==========================================
- Hits       470007   469861     -146     
+ Misses      66387    66376      -11     
  Partials      366      366              

@asottile-sentry asottile-sentry force-pushed the asottile-some-dead-code-tsdb branch from 85b1cca to 0f8df0d Compare January 7, 2025 19:05
@asottile-sentry asottile-sentry merged commit 8edb1f5 into master Jan 7, 2025
48 checks passed
@asottile-sentry asottile-sentry deleted the asottile-some-dead-code-tsdb branch January 7, 2025 19:32
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
no callers in getsentry or sentry

found via https://github.com/asottile/dead

<!-- Describe your PR here. -->
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants