-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: delete some dead methods from tsdb #83008
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Automatically applied to PRs that change backend components
label
Jan 7, 2025
asottile-sentry
force-pushed
the
asottile-some-dead-code-tsdb
branch
from
January 7, 2025 17:57
61df929
to
a040135
Compare
JoshFerge
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩
asottile-sentry
force-pushed
the
asottile-some-dead-code-tsdb
branch
from
January 7, 2025 18:06
a040135
to
3453bcf
Compare
wedamija
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good to prune tsdb as much as possible
asottile-sentry
force-pushed
the
asottile-some-dead-code-tsdb
branch
from
January 7, 2025 18:34
3453bcf
to
85b1cca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83008 +/- ##
==========================================
- Coverage 87.56% 87.56% -0.01%
==========================================
Files 9419 9419
Lines 536760 536603 -157
Branches 21115 21115
==========================================
- Hits 470007 469861 -146
+ Misses 66387 66376 -11
Partials 366 366 |
asottile-sentry
force-pushed
the
asottile-some-dead-code-tsdb
branch
from
January 7, 2025 19:05
85b1cca
to
0f8df0d
Compare
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
no callers in getsentry or sentry found via https://github.com/asottile/dead <!-- Describe your PR here. -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no callers in getsentry or sentry
found via https://github.com/asottile/dead