feat(issue-views): add query counts back to tabs #82990
Open
+253
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
❌ 10 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
MichaelSun48
force-pushed
the
msun/issueViews/addQueryCountsBack
branch
from
5469cbb to
5fd797d
Compare
MichaelSun48
force-pushed
the
msun/issueViews/addQueryCountsBack
branch
from
5fd797d to
fcf22f7
Compare
MichaelSun48
commented
Jan 7, 2025
| @@ -144,6 +144,7 @@ const UnselectedTabTitle = styled('div')<{isSelected: boolean}>` | |||
| text-overflow: ellipsis; | |||
| padding-right: 1px; | |||
| cursor: pointer; | |||
| line-height: 1.45; | |||
There was a problem hiding this comment.
Very minor change to align the view name better with the count:
Before:
After:
malwilley
reviewed
Jan 7, 2025
MichaelSun48
commented
Jan 7, 2025
| @@ -31,6 +31,7 @@ export const useFetchIssueCounts = ( | |||
| ) => { | |||
| return useApiQuery<QueryCounts>(makeFetchIssueCounts(params), { | |||
| staleTime: 0, | |||
| placeholderData: keepPreviousData, | |||
There was a problem hiding this comment.
We want to keep previous data while new data loads so that the query count bubble doesn't change size while the new count loads. If this were not here, the previous data would be scrubbed, and the query count bubble would lose its content and shrink to its min width before growing again.
|
@malwilley both of those were unintentional bugs and are fixed now! |
malwilley
reviewed
Jan 7, 2025
|
@MichaelSun48 some failing tests! Also noticed that the loading state looks too white in dark mode:
And it may make sense to increase the stale time for the hook that fetches these counts. If you go to another page and come back it refetches everything and shows the loading state, which can be very long for some of my views |
MichaelSun48
commented
Jan 8, 2025
Comment on lines
+86
to
+89
| expect(await screen.findByRole('tab', {name: /High Priority/})).toBeInTheDocument(); | ||
| expect(screen.getByRole('tab', {name: /Medium Priority/})).toBeInTheDocument(); | ||
| expect(screen.getByRole('tab', {name: /Low Priority/})).toBeInTheDocument(); | ||
| expect(screen.getByRole('tab', {name: /High Priority/})).toHaveAttribute( |
There was a problem hiding this comment.
Somewhat jank way to fix the test failures - because the queryCount and tab title were adjacent components, RTL concatenated the strings, so the name of the "High Priority" tab with 12 counts would register "High Priority 12" instead of just "High Priority". I tried a bunch of things in the component themselves to make it work, but it ended up getting more complex than it should be to just make tests work, and I'd rather have the jank live in tests rather than in the components.
MichaelSun48
commented
Jan 8, 2025
| animate={{ | ||
| backgroundColor: queryCountFetching | ||
| ? [theme.surface400, theme.surface100, theme.surface400] | ||
| : `#00000000`, |
There was a problem hiding this comment.
I think there are some issues with just using 'transparent' here - there are some consloe warnings about not being able to interpolate the hex values with the transparent keyword, hence why we're using #000000 here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending this PR to be merged.Adds the query count back to issue view tabs, this time with a hard max of 99 (counts will not go above 99 even after clicking into the tab, unlike before).
Temp view also works: