Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(explore): Expose more span attributes #82966

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Jan 6, 2025

Based on a quick audit of insights, these fields were missing from explore.

Based on a quick audit of insights, these fields were missing from explore.
@Zylphrex Zylphrex requested a review from a team as a code owner January 6, 2025 22:25
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 6, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #82966      +/-   ##
==========================================
- Coverage   87.55%   84.63%   -2.93%     
==========================================
  Files        9411     9427      +16     
  Lines      536904   536757     -147     
  Branches    21113    21061      -52     
==========================================
- Hits       470107   454282   -15825     
- Misses      66431    81978   +15547     
- Partials      366      497     +131     

Copy link
Contributor

@DominikB2014 DominikB2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Took a quick scan and lgtm! I imagine if there's any more adjustments, it can be easily added here later on?

@Zylphrex
Copy link
Member Author

Zylphrex commented Jan 7, 2025

Awesome! Took a quick scan and lgtm! I imagine if there's any more adjustments, it can be easily added here later on?

Yes, we can add more as needed

@Zylphrex Zylphrex merged commit 3d67b60 into master Jan 7, 2025
48 checks passed
@Zylphrex Zylphrex deleted the txiao/chore/expose-more-span-attributes branch January 7, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants