Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: remove monitor checkin attachments backend #82891

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ref: remove monitor checkin attachments backend #82891

wants to merge 1 commit into from

Conversation

asottile-sentry
Copy link
Member

@asottile-sentry asottile-sentry commented Jan 3, 2025 •
edited
Loading

blocked on #82890
also blocked on https://github.com/getsentry/getsentry/pull/16033

will remove the attachment_id column in a followup

@asottile-sentry asottile-sentry requested review from a team as code owners January 3, 2025 21:22
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 3, 2025
@asottile-sentry asottile-sentry mentioned this pull request Jan 3, 2025
Open
@asottile-sentry asottile-sentry force-pushed the asottile-remove-checkin-attachments-be branch from 6388aae to 5b4d4ff Compare January 3, 2025 22:14
@getsantry getsantry bot requested a review from a team as a code owner January 3, 2025 22:21
wedamija
wedamija reviewed Jan 3, 2025
View reviewed changes
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this all up. @gaprl is back next week, I'd like to just confirm with him that we're fine to remove all of this before I approve

@asottile-sentry asottile-sentry force-pushed the asottile-remove-checkin-attachments-be branch from 394b84d to 03f1e47 Compare January 3, 2025 23:20
@asottile-sentry asottile-sentry force-pushed the asottile-remove-checkin-attachments-be branch from 03f1e47 to f0917c1 Compare January 3, 2025 23:21
wedamija
wedamija approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, confirmed that we don't need any of this. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wedamija wedamija wedamija approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asottile-sentry @wedamija