Native stack traces: registers are hidden, button to show them is displaced #82641

nipunh · 2024-12-28T16:34:20Z

Native stack traces: registers are hidden, button to show them is displaced #82371

Resolved the overflow issue
Always showing the "teaser" view of the registers initially

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

False as a value in dropdown was causing unexpected behaviour

This reverts commit ea6a831.

ryan953 · 2024-12-31T04:04:02Z

static/app/components/events/interfaces/nativeFrame.tsx

@@ -91,7 +91,6 @@ function NativeFrame({
  isShowFramesToggleExpanded,
  isSubFrame,
  onShowFramesToggle,
-  isExpanded,


This should also be removed from the Props type above. Any callsites that are passing it in will have to be updated as well.

I will take a look and make required changes for it.

@nipunh Don't forget about cleaning up this extra prop in the types and callsites ^

Hi @ryan953, I have pushed the changes after clean this up.

@nipunh Please also delete line 63 from this file, the content is isExpanded?: boolean;
Then typescript should be happy, and we'll be all set!

ryan953 · 2024-12-31T04:11:55Z

static/app/components/events/interfaces/nativeFrame.tsx

+  grid-template-columns: auto 150px 120px 4fr repeat(3, auto) ${space(2)}; /* Adjusted to account for the extra element */
+  grid-template-rows: 1fr; /* Ensures a single row */


I suspect that the grid columns will depend on the values of expandable and hiddenFrameCount. I will find some sample data to look at before I can know what to do here.

Also, the specific grid-column and grid-row css inside each *Cell component seem like they're going to expect a specific number of columns, and two rows, if only at the small breakpoint.

Thanks for the feedback, Once we have clarity from the data, I can help refine the grid logic further. Let me know your findings!

Just to make sure, I am on the right path here, The button (show/hide count) doesn't add a data column but instead adds an extra row header without a corresponding data column. This mismatch causes layout issues like pushing the ExpandCell to the next line.

It looks like it's supposed to go into two rows on purpose when the window is narrow. But the colunm widths in that case are kind of broken right now:

Can you re-test with a normal-width browser, and a narrow browser window, and share screenshots of the results.

I think you'll want to have something like grid-template-rows: repeat(2, auto); with appropriate widths defined for the narrow @media breakpoint.

Sure, I will test and share the screenshots.

Hi @ryan953

These are the screenshots for the existing code.

These are the screenshots after the change

I have also included the screen size in the screenshots.

awesome! I wanted to see if stuff like that In App tag was still moved down to the second row, looks like it is!

Great! Is there anything else I can update here?

@nipunh don't forget about that extra isExpanded prop, we don't need it in the Props definition or at the callsites anymore.

Yes, Verifying that and will push the changes soon.

removed unused Props from callsites that are passing it

…ub.com/nipunh/sentry into nipun/improvement/registers-are-hidden

…placed (#82641)  Native stack traces: registers are hidden, button to show them is displaced #82371 1) Resolved the overflow issue 2) Always showing the "teaser" view of the registers initially ![Screenshot 2024-12-28 at 11 30 51 AM](https://github.com/user-attachments/assets/6aa8683b-cd11-4c77-b2c2-ed4ff4f25541)  ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Expands the first in native in app frame. It was changed to expand all by default, this causes the stacktrace link to make requests for every line which is not what the github api can handle. related #82641 fixes #84045

nipunh added 2 commits December 22, 2024 19:52

always show register teaser

cadb5fc

updated the row header style to resolve overflow

2aef46f

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 28, 2024

nipunh mentioned this pull request Dec 28, 2024

Native stack traces: registers are hidden, button to show them is displaced #82371

Closed

nipunh added 3 commits December 28, 2024 11:49

Merge branch 'master' into nipun/improvement/registers-are-hidden

6758420

changed value checks

ea6a831

False as a value in dropdown was causing unexpected behaviour

Revert "changed value checks"

785e564

This reverts commit ea6a831.

nipunh changed the title ~~Nipun/improvement/registers are hidden~~ Native stack traces: registers are hidden, button to show them is displaced Dec 29, 2024

nipunh mentioned this pull request Dec 31, 2024

Account Notification Settings Input Issues (UI only) #82642

Merged

ryan953 linked an issue Dec 31, 2024 that may be closed by this pull request

Native stack traces: registers are hidden, button to show them is displaced #82371

Closed

ryan953 added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Dec 31, 2024

vercel bot deployed to Preview December 31, 2024 03:58 View deployment

ryan953 requested a review from a team December 31, 2024 03:58

ryan953 reviewed Dec 31, 2024

View reviewed changes

code cleanup

e3206a8

removed unused Props from callsites that are passing it

nipunh requested a review from a team as a code owner January 10, 2025 04:35

github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jan 10, 2025

nipunh added 3 commits January 9, 2025 23:35

Merge branch 'master' into nipun/improvement/registers-are-hidden

2ad8cca

cleanup

d0fd114

Merge branch 'nipun/improvement/registers-are-hidden' of https://gith…

397c0aa

…ub.com/nipunh/sentry into nipun/improvement/registers-are-hidden

ryan953 added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jan 10, 2025

ryan953 approved these changes Jan 10, 2025

View reviewed changes

ryan953 merged commit 1aee795 into getsentry:master Jan 10, 2025
40 of 42 checks passed

cobyeastwood183 mentioned this pull request Jan 24, 2025

Issue Page - Missing GitHub Icons/Links #84045

Closed

scttcper mentioned this pull request Jan 24, 2025

fix(issues): Only expand first native frame #84046

Merged

github-actions bot locked and limited conversation to collaborators Jan 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Native stack traces: registers are hidden, button to show them is displaced #82641

Native stack traces: registers are hidden, button to show them is displaced #82641

nipunh commented Dec 28, 2024

ryan953 Dec 31, 2024

nipunh Dec 31, 2024

ryan953 Jan 7, 2025 •

edited

Loading

nipunh Jan 10, 2025 •

edited

Loading

ryan953 Jan 10, 2025

nipunh Jan 10, 2025

ryan953 Dec 31, 2024 •

edited

Loading

nipunh Dec 31, 2024

ryan953 Dec 31, 2024 •

edited

Loading

nipunh Jan 1, 2025

nipunh Jan 4, 2025 •

edited

Loading

ryan953 Jan 6, 2025

nipunh Jan 7, 2025

ryan953 Jan 7, 2025

nipunh Jan 7, 2025

		grid-template-columns: auto 150px 120px 4fr repeat(3, auto) ${space(2)}; /* Adjusted to account for the extra element */
		grid-template-rows: 1fr; /* Ensures a single row */

Native stack traces: registers are hidden, button to show them is displaced #82641

Native stack traces: registers are hidden, button to show them is displaced #82641

Conversation

nipunh commented Dec 28, 2024

Legal Boilerplate

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryan953 Jan 7, 2025 • edited Loading

Choose a reason for hiding this comment

nipunh Jan 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryan953 Dec 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryan953 Dec 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nipunh Jan 4, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryan953 Jan 7, 2025 •

edited

Loading

nipunh Jan 10, 2025 •

edited

Loading

ryan953 Dec 31, 2024 •

edited

Loading

ryan953 Dec 31, 2024 •

edited

Loading

nipunh Jan 4, 2025 •

edited

Loading