Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tempest): Add cron job and tasks #82454

Merged
merged 18 commits into from
Jan 14, 2025

Conversation

tobias-wilfert
Copy link
Member

@tobias-wilfert tobias-wilfert commented Dec 20, 2024

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 96.61836% with 7 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/tempest/tasks.py 90.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #82454      +/-   ##
==========================================
- Coverage   87.53%   87.50%   -0.03%     
==========================================
  Files        9481     9403      -78     
  Lines      537762   537550     -212     
  Branches    21178    21178              
==========================================
- Hits       470711   470393     -318     
- Misses      66701    66807     +106     
  Partials      350      350              

@tobias-wilfert tobias-wilfert changed the title WIP: feat(tempest) Add cron job and tasks WIP: feat(tempest): Add cron job and tasks Jan 8, 2025
@tobias-wilfert tobias-wilfert changed the title WIP: feat(tempest): Add cron job and tasks feat(tempest): Add cron job and tasks Jan 8, 2025
Copy link
Member

@shellmayr shellmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - as discussed, please have @vgrozdanic sign this off to make sure his comments have been addressed.

@tobias-wilfert tobias-wilfert marked this pull request as ready for review January 13, 2025 15:05
@tobias-wilfert tobias-wilfert requested a review from a team as a code owner January 13, 2025 15:05
Copy link
Member

@vgrozdanic vgrozdanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tobias-wilfert tobias-wilfert merged commit 8705835 into master Jan 14, 2025
49 checks passed
@tobias-wilfert tobias-wilfert deleted the tobias-wilfert/feat/add-tempest-tasks branch January 14, 2025 10:20
vgrozdanic added a commit that referenced this pull request Jan 14, 2025
Few hours ago #82454 was
deployed, but there we have missed to register celery tasks which cause
another error:
https://sentry.sentry.io/issues/4271076192/?project=1&query=is%3Aunresolved%20sentry.tempest.tasks.poll_tempest&referrer=issue-stream&sort=date&statsPeriod=2h&stream_index=0

This PR registers the celery tasks and should also fix the Sentry error
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
Few hours ago #82454 was
deployed, but there we have missed to register celery tasks which cause
another error:
https://sentry.sentry.io/issues/4271076192/?project=1&query=is%3Aunresolved%20sentry.tempest.tasks.poll_tempest&referrer=issue-stream&sort=date&statsPeriod=2h&stream_index=0

This PR registers the celery tasks and should also fix the Sentry error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants