Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): Update insufficient samples warning #82132

Merged
merged 2 commits into from
Dec 17, 2024
Merged

feat(explore): Update insufficient samples warning #82132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb18959
feat(explore): Update insufficient samples warning
Zylphrex Dec 15, 2024
df7fae5
put back confidence
Zylphrex Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 26 additions & 16 deletions static/app/views/explore/charts/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {
prettifyParsedFunction,
} from 'sentry/utils/discover/fields';
import {DiscoverDatasets} from 'sentry/utils/discover/types';
import {formatPercentage} from 'sentry/utils/number/formatPercentage';
import {MutableSearch} from 'sentry/utils/tokenizeSearch';
import usePageFilters from 'sentry/utils/usePageFilters';
import usePrevious from 'sentry/utils/usePrevious';
Expand Down Expand Up @@ -353,24 +352,31 @@ export function ExploreCharts({query, setConfidence, setError}: ExploreChartsPro
/>
{dataset === DiscoverDatasets.SPANS_EAP_RPC && (
<ChartFooter>
{defined(extrapolationMetaResults.data?.[0]?.['count_sample()']) &&
defined(
extrapolationMetaResults.data?.[0]?.['avg_sample(sampling_rate)']
)
? tct(
'*[sampleCount] samples extrapolated with an average sampling rate of [sampleRate]',
{
{!defined(extrapolationMetaResults.data?.[0]?.['count_sample()'])
? t('* Extrapolated from \u2026')
: resultConfidence === 'low'
? tct('* Extrapolated from [insufficientSamples]', {
insufficientSamples: (
<Tooltip
title={t(
'Boost accuracy by shortening the date range, increasing the time interval or removing extra filters.'
)}
>
<InsufficientSamples>
{t('insufficient samples')}
</InsufficientSamples>
</Tooltip>
),
})
: tct('* Extrapolated from [sampleCount] samples', {
sampleCount: (
<Count
value={extrapolationMetaResults.data[0]['count_sample()']}
value={
extrapolationMetaResults.data?.[0]?.['count_sample()']
}
/>
),
sampleRate: formatPercentage(
extrapolationMetaResults.data[0]['avg_sample(sampling_rate)']
),
}
)
: t('foo')}
})}
</ChartFooter>
)}
</ChartPanel>
Expand Down Expand Up @@ -401,7 +407,7 @@ function useExtrapolationMeta({
const discoverQuery: NewQuery = {
id: undefined,
name: 'Explore - Extrapolation Meta',
fields: ['count_sample()', 'avg_sample(sampling_rate)', 'min(sampling_rate)'],
fields: ['count_sample()', 'min(sampling_rate)'],
query: search.formatString(),
version: 2,
dataset,
Expand Down Expand Up @@ -455,3 +461,7 @@ const ChartFooter = styled('div')`
margin-top: ${space(1.5)};
margin-bottom: 0;
`;

const InsufficientSamples = styled('span')`
text-decoration: underline dotted ${p => p.theme.gray300};
`;
12 changes: 0 additions & 12 deletions static/app/views/explore/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,6 @@ function ExploreContentImpl({}: ExploreContentProps) {
</Layout.HeaderActions>
</Layout.Header>
<Body>
{confidence === 'low' && (
<ConfidenceAlert type="warning" showIcon>
{t(
'Your low sample count may impact the accuracy of this extrapolation. Edit your query or increase your sample rate.'
)}
</ConfidenceAlert>
)}
<TopSection>
<StyledPageFilterBar condensed>
<ProjectPageFilter />
Expand Down Expand Up @@ -225,11 +218,6 @@ const Body = styled(Layout.Body)`
}
`;

const ConfidenceAlert = styled(Alert)`
grid-column: 1/3;
margin: 0;
`;

const TopSection = styled('div')`
display: grid;
gap: ${space(2)};
Expand Down
Loading