Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FilestoreNodeStorage #82125

Closed
wants to merge 1 commit into from
Closed

feat: FilestoreNodeStorage #82125

wants to merge 1 commit into from

Conversation

rophy
Copy link

@rophy rophy commented Dec 15, 2024

See #76250 (comment)

While the original PR says "S3 Node Store", all the S3 logics actually come from configured File Store.
So I think "FilestoreNodeStorage" is probably a better term to describe the brilliant idea from @klboke

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 15, 2024
@rophy
Copy link
Author

rophy commented Dec 15, 2024

Closing this in favor of PR based on non-master branch in #82126

@rophy rophy closed this Dec 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant